Skip to content

(Ready)fix: handle multiple copilot server instances - #387

Merged
AntoineGS merged 6 commits into
zbirenbaum:masterfrom
yingmanwumen:master
Mar 21, 2025
Merged

(Ready)fix: handle multiple copilot server instances#387
AntoineGS merged 6 commits into
zbirenbaum:masterfrom
yingmanwumen:master

Conversation

@yingmanwumen

@yingmanwumen yingmanwumen commented Mar 21, 2025

Copy link
Copy Markdown
Contributor
  • Stop old client instance instead of erroring when multiple servers are started
  • Replace deprecated vim.loop with vim.uv

background: #386

Lin Zhenyun
fix: handle multiple copilot server instances
0813d95 
- Stop old client instance instead of erroring when multiple servers
  are started
- Replace deprecated vim.loop with vim.uv
@yingmanwumen yingmanwumen changed the title fix: handle multiple copilot server instances (Draft)fix: handle multiple copilot server instances Mar 21, 2025
Lin Zhenyun added 2 commits March 21, 2025 17:41
Lin Zhenyun
fix: avoid LSP error with unsupported window/logMessage
0395415 
Some LSP servers like jsonlsp don't support window/logMessage method,
causing potential errors. Move the handler to client config to avoid this.
Lin Zhenyun
fix: add required editor info for LSP initialization
fe3b387 
Fix LSP warning by providing required editorInfo and editorPluginInfo fields
in initializationOptions for the Copilot LSP client.
@yingmanwumen yingmanwumen changed the title (Draft)fix: handle multiple copilot server instances (Ready)fix: handle multiple copilot server instances Mar 21, 2025
@yingmanwumen

yingmanwumen commented Mar 21, 2025

Copy link
Copy Markdown
Contributor Author

@AntoineGS Hello, I've fixed some warning and error :) Could you please have a look when you are free?

@AntoineGS

AntoineGS commented Mar 21, 2025

Copy link
Copy Markdown
Collaborator

I've pushed a fix for the multiple instances instead of merging this PR as there are a couple of less critical changes in this one and wanted more time to review them.
Thanks for the heads up!
I will review the rest shotly.

@yingmanwumen

yingmanwumen commented Mar 21, 2025

Copy link
Copy Markdown
Contributor Author

I've pushed a fix for the multiple instances instead of merging this PR as there are a couple of less critical changes in this one and wanted more time to review them.

sure 😀 you can also review my commits separately, each of them has solved a tiny issue

@AntoineGS

AntoineGS commented Mar 21, 2025

Copy link
Copy Markdown
Collaborator

Could you create a separate PR for the handler change?
Having a PR per feature makes it whole lot easier (I will have some changes to add to the editorInfo part so it will get messy) :)

@yingmanwumen

yingmanwumen commented Mar 21, 2025

Copy link
Copy Markdown
Contributor Author

Could you create a separate PR for the handler change?
Having a PR per feature makes it whole lot easier (I will have some changes to add to the editorInfo part so it will get messy) :)

Sure, but I am a little busy now, so you may have to wait for minutes/hours

@AntoineGS

AntoineGS commented Mar 21, 2025

Copy link
Copy Markdown
Collaborator

No worries I will get creative this time around and split them

@AntoineGS
AntoineGS merged commit 1f893df into zbirenbaum:master Mar 21, 2025
@github-actions github-actions Bot mentioned this pull request Mar 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yingmanwumen @AntoineGS